Remove Debug bound from various traits#860
Closed
philipc wants to merge 1 commit intogimli-rs:masterfrom
Closed
Conversation
Remove `Debug` bound from `Reader`, `ReaderOffset`, `UnwindSection` and `UnwindOffset`. This isn't necessary for their operation, and users can define their own trait if they require it. There's a bit of complexity to get the derived Debug implementations to work correctly with associated types. We already had this sort of thing in a lot of places because it helps with lifetime variance too. Also reduce the places where the dwarfdump example uses Debug to print.
Collaborator
Author
|
In addition to the complexity, this change means we can no longer use things like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Debugbound fromReader,ReaderOffset,UnwindSectionandUnwindOffset. This isn't necessary for their operation, and users can define their own trait if they require it.There's a bit of complexity to get the derived Debug implementations to work correctly with associated types. We already had this sort of thing in a lot of places because it helps with lifetime variance too.
Also reduce the places where the dwarfdump example uses Debug to print.